Gem Vault

[HADES-HL]

Just to check, if I get it right, this module allows to store gems in the bank and not more?

If that's right, I don't see any utility.

[Kendaer]

Well, it's a way of avoid random gem-loss events which is why it's never a candidate for the core code

[HADES-HL]

Well, it's a way of avoid random gem-loss events which is why it's never a candidate for the core code

And that is good!
I think there MUST be a chance of getting a bad result in a event, otherwise no one would think about geoing into Stonehenge or something like that...

[aes]

I agree it's a bit of a cheat to be able to store gems in the bank.    I've batted around the idea of limiting the amount a player can store but haven't taken it further...   This module has a bit of history in that I implemented it when I was running 0.9.7 without thinking too much of the consequences and as such my users grew to like it.  So when 0.9.8 came out I thought I'd make a module of it to get used to the module system and to appease my users!

That’s probably more than you all care to know.  

[Spider]

well the 97 gem addition to the bank allowed you to store up to 10 gems, any more and you would lose the extra at a new day (thanks to a theif).  This wouldn't be too hard to implement if you wanted, and it does the job nicely, gives you a little storage and security but you still have to carry some around.

Unless of course you can be bothered to deposit all your gems at the start of the day and take them out at the end.

[strider]

I have to say, I've never been fond of gem vaults of any sort within my realms... It causes more unbalance quicker than needed.

[Arune]

Old thread I know but I had been using this until recently I switched to Spider's mod...I didn't realize at first that this allowed unlimited storage and did not clear the gems upon DK.

I had users with 2100+ gems bank....

So as a heads up to everyone, I'm not sure if there are updates planned to fix this but currently you can if (AES) allows..

in the file below:

Code:

module_addhook("footer-bank");

insert:

Code:

module_addhook("dragonkill");

and then after:

Code:

addnav("Gems");
addnav("Gem Vault - Being Removed","runmodule.php?module=bankgems&op=gemvault");
 break;

insert:

Code:

       case "dragonkill":
        set_module_pref('gemsinbank',0);
        break;

I know this is like a flashback of 0.9.7 *grin* but it works...and I wasn't sure what Aes would think of me posting his module modified...etc.

Anyway that will clear the vault every DK. *WARNING* there still isn't any limit as to how much is allowed to be stored.

Arune

[lonnyl]

Hehehe.... been running this for some time..... just found a player exploiting it in a hefty way.... they were opening an account... withdrawing gems.... and opening an account again.  This would give the player a gem for 1000 gold..... then they would run off and sell the gem at vessa's (I know I shouldn't run it but i'd be lynched for removing it).  They were making a killing going back and forth.  This module would give the player a free gem each time they open an account..... there are also some missing settings in the game editor that I have added.  The player now has to have a gem to open an account and it take their gem to start the account (no more cheap gems).  

I also should note that there is now an admin settable limit to gems in the vault.
 
http://dragonprime.net/users/lonnyl/bankgems.zip

[Sichae]

Just gonna update this further.

Version 1.4

Now with DK emptying, ability to alter through user editor, Lonny's fixes as well. My own fixes, to Lonny's code, which includes a simplification of linecount, as well as lessening of variable length.

When a user buys an account, it sets a pref, that is only reset upon DK. So, no exploiting there.

Also quite translation compatable.

http://dragonprime.net/users/Sichae/bankgems.zip

[lonnyl]

Beware version 1.4....
This will take all of your players banked gems away and they will attemt to lynch you!  

I added

Code:

if ($gib > 0 and get_module_pref("cacc") == 0) set_module_pref("cacc",1);

after

Code:

$gib = get_module_pref("gemsinbank");

this will activate the account if the player already has gems stored in the vault...

also the setting for having an account is defined as cacc and hacc in the module... I changed them all to cacc to make things work.

[Sichae]

Version 1.41

With Lonny's little fix.

I used hacc, as in "Has Account"

Same Link.

[lonnyl]

The version in your download section shows 1.4, your version.txt shows 1.41.
The hacc pref is good everywhere except in module info where it is still as cacc...

[Sichae]

Fixed.

[ShadowRaven]

I just downloaded the 1.41 version and thought you should know that its still "cacc" in the prefs:


"prefs"=>array(
                        "Gem Vault User Preferences,title",
                                "gemsinbank"=>"Amount of Gems in Bank,int|0",
                                "cacc"=>"Has user created an account,bool|0",
                )
        );
        return $info;
}
function bankgems_install(){
        module_addhook("footer-bank");
        module_addhook("dragonkilltext");
        return true;
}
function bankgems_uninstall(){
        return true;
}
function bankgems_dohook($hookname,$args){
        global $session;
        switch($hookname){
                case "footer-bank":
                        addnav("Gems");
                        addnav("Gem Vault","runmodule.php?module=bankgems&op=enter");
                        break;
                case "dragonkilltext":
                        if (get_module_setting("dktake") == 1) set_module_pref("gemsinbank",0);
                        set_module_pref("hacc",0);
                        break;

[Sichae]

Updated.