Beta release - LotGD v1.11 - DragonprimeEdition

[XChrisX]

This is plainly impossible... Bluntly said: That's a big lie.

[tyranny]

For modules, does this mean that most 1.x.x mods will work, but that any with those two battle hooks will need to be rewritten?

[XChrisX]

Not really rewritten. You need to add a few lines.

Instead of

Code:

case "battle-victory":
  do_sthings();
  break;

you now have to

Code:

case "battle-victory":
  static $runonce = false;
  if ($runonce === false) {
    do_things();
    $runonce = true;
  }
  break;

This is one way. The final release will most likely contain a battle-victory-runonce hook, so you'd only need to change the hooks' names...

[dilbert166]

i´m thinking about upgrading my 1.1.0 to 1.1.1. i understand there have been changes to a few things, as far as module support are concerned. is there some kind of "idiot´s guide to what you have change in your installed modules" or anything, so that i can check, which modules i would have to modify? if not, could someone compile a list of things, that will definitely not work anymore (i don´t mean a list of modules, more a list of "if your mod uses this function/method/hook x, you have to modify it to y")?

[XChrisX]

If you mod uses the forementioned hooks, they might execute more than once in a fight (by now).

[dilbert166]

If you mod uses the forementioned hooks, they might execute more than once in a fight (by now).

yes, i got that. question was more, if there are other known functions/hooks etc that react different compared to 1.1.0, which would require further modification of the mods i have installed.

[XChrisX]

not really. All changes we made were under the great commandment: "THOU SHALL NOT CHANGE A FUNCTION'S BEHAVIOUR!"

[Adept]

not really. All changes we made were under the great commandment: "THOU SHALL NOT CHANGE A FUNCTION'S BEHAVIOUR!"

awww it always permissible to change a function behavior.  as long as add a new parm for new versus old behavior ... default set to old 

[Nightborn]

> cancelpetition] =
> [cancelreason] = The admins here decided they didn't like something

ah, where is the documentation for that feature/fix whatever it is?

I wonder what else got silently introduced and nobody is aware of 

[rolland]

good job to everyone who worked on this. 

[SaucyWench]

> cancelpetition] =
> [cancelreason] = The admins here decided they didn't like something

ah, where is the documentation for that feature/fix whatever it is?

I wonder what else got silently introduced and nobody is aware of 

We have this on Central/Classic. Eric did it for anti-spam, it's to fool the bots. Anything that DOESN'T have this is filtered I think... it is a hidden field so if the bot fills it with something else it triggers.

So, it may be in 1.0.6? If not, then someone pasted Eric's fix into 1.1.0 I think.

[Nightborn]

it was not in the 1.1.1 snapshot I worked on until Oct =)

So it was introduced there, but well.
Anti-Spam can be done via module, I have an example here at my hands that I wrote and it works. My fields are [captcha].

This "hidden field" appearing does not make me feel very comfortable as I don't know what else might be "hidden".

[arieswind]

NOTE FOR DEVELOPERS: Any module using the hooks "battle-victory" or "battle-defeat" HAVE TO BE REWORKED!. The core now still holds some kind of legacy support. But this will be removed for the final version. It is imperative that you update your modules or they will cause havoc!

"battle-victory" and "battle-defeat" are disappearing? what if i want to use them even if they work differently?

[XChrisX]

They are not disappaering. They will be changed into
"battle-victory" and "battle-victory-runonce"

[Dragon89]

Sweet!  That solves a lot of issues for modules that hooked battle-victory.  Will this be available in SVN soon, and how or where can I get a SVN checkout from?  I will gladly setup a beta server and have players test the v1.1.1 code.  Please send a PM 

Thanks
~D