Chat Color

[DeathDragon]

A lot of my users complain about having to type `! or `% or whatever color they type in..so they asked me to make something in the preferences that lets them pick a chat color to use..well I made it and I got it so that it works in the preview too...just download my commentary.txt and my prefs.txt files and upload them! This is for 0.9.8 and yes I did test it

[DeathDragon]

Here are the download links:

commentary.txt
prefs.txt

[Talisman]

There are a few problems with what you've posted:

- They are not modules, they are patches.  You need to specify that, and there will soon be a separate area for patches.

- You have modified core files without commenting the fact, which will cause problems down the road. When you create a patch, it should be distributed as a list of instructions for modifying the files.

[DeathDragon]

Oh sorry..I don't remember how much I changed...or exactly what I changed...sorry....

[DeathDragon]

I know you guys probably hate me but I'm just trying to give back for all the mods everyone here has given............

[DeathDragon]

Well..if anyone does decide to try it and maybe figures out what I did to make it work that would be awesome..sorry that I can't remember..

[Kendaer]

Please learn how to use Diff.

Btw, also please make sure to use '' around words being used as array indices.

(IE, you did $prefs[ccolor], rather than the preferred and correct $prefs['ccolor'])

Personally, I dislike this patch because it makes it 'obvious' what each color code is, when that is something that people are intended to learn as time goes on by (for instance) visiting the Dark Horse and talking to the guy there.

With this, all you would have to do is look in your preferences :/

[DeathDragon]

Hmm..well maybe I could make it so that if you went to the dark horse tavern and bought it then the thing would pop up in the preferences......

[DeathDragon]

Or maybe after they have used each color it will show up in the preferences....

[Kendaer]

Also, something else I noticed when I looked at it is that the way this is set up it overrides whatever color someone else choses to display in by default into whatever this person's color is.

All in all, this is not (imho) a good modification.

[phofire]

Idea good, i think the implementation just needs work. some of your ideas raz are good theories, possible (if code allows) have the player have to rough type in the way there chat begins and have it display, i have seen this done elsehwer just not sure if possible here. But the ability to not do it till you know better is good and typing it into prefs will allow this for those that are familiar with the colors but not have found the tavern