PVP not working?

[Foolish Frost]

Well.  I have the bounty system working,  and when people retire to the fields they are listed as attackable, but when you click on it, nothing happens.

No error.  Nothing.

I did a search and found nothing like this.  Any ideas?

And yes, it's turned on.

[Talisman]

Does it load another page?  Is there a message saying that person isn't attackable yet?

[SexyCook]

Does it give you ..../badnav.php as the url?

[Foolish Frost]

Does it give you ..../badnav.php as the url?

Well, what'd'ya know!

That's it!

Anybody have any ideas why, as to reduce the debug time?  I can go through the process, but hints are always nice!

 

[Talisman]

Could be due to a module you have installed, but nobody can tell you without a link to your server...

[Foolish Frost]

Could be due to a module you have installed, but nobody can tell you without a link to your server...

I can.

Simple issue, with a bugger of a problem:

My players have spaces in thier names...

All of them...

<sigh>

It's even an option in the system, and yet it falls apart when used.

Suggestions no how to recode this so it works?  Why does the sapce in the name cause the badnav reaction?  Can I clean something up to fix it?

[Foolish Frost]

Does this have to do with the problem of spaces becomming %20 ?  The listing of allows navs in badnav is not equalling each other?

[XChrisX]

in lib/pvplist.php find this code:

Code:

if($row['pvpflag']>$pvptimeout){

beneath it should show something like this:

Code:

output("`i(Attacked too recently)`i");
}elseif ($location!=$row['location']){
output("`i(Can't reach them from here)`i");
}else{
rawoutput("<a href='$link$extra&name=".rawurlencode($row['login'])."'>$att</a>");
addnav("","$link$extra&name=".rawurlencode($row['login']));
}

make sure the rawurlencode is there in the last lines.

[Talisman]

I just successfully pvp'd a player with a space in it's name on my version 1.1.0 test server.  I don't think the problem is core related (although I've been wrong before).  What version are you using?

[Foolish Frost]

1.1.0 for version.

XChrisX, good call, but no.  All of that code is exactly as you show it.

And confirmed:  I can kill single name characters...

Looks about.  You just know it's going to be one line in 10000, don'tcha?

<sigh>

[Sichae]

This is the second case I've seen in the past few days... but try changing line 38 of pvp.php to:

Code:

$name = rawurldecode(httpget('name'));

If you are going to encode something, make sure to decode it on the other end.

[Foolish Frost]

nope.  not working yet...

[XChrisX]

this should definately be switched to acctid instead of login...

[Foolish Frost]

Aye, but your talking a lot of module reconstruction too, I would think...

Let me ask this:  WHat code determins something is a badurl?  Perhaps THAT code needs the decode line...  I can say for certain that pvp.phgp is never getting an actual call, because I put exit; near the top and badurl still does not work.

Oh, and the bio link fails as well...

This HAS to do with spaces.  It's all I got...

[XChrisX]

No, the checking of navs works perfectly... It's just that (so it seems) some server configurations automatically encode and decode things...

Switching this to "acctid" will not harm a lot modules... There's only one module I know, which uses this and that already masks the login...