DragonPrime - LoGD Resource Community
Welcome Guest
  • Good morning, Guest.
    Please log in, or register.
  • October 19, 2017, 02:08:09 AM
Home Forums News Downloads Login Register Advanced Search
* * *
DragonPrime Menu
Login
 
 
Resource Pages
Search

Pages: [1]   Go Down
  Print  
Author Topic: Hardest hit  (Read 2707 times)
0 Members and 1 Guest are viewing this topic.
XChrisX
Global Moderator
Mod God
*****
Offline Offline

Posts: 4647

Be aware of the squirrel!


View Profile WWW
« on: March 09, 2005, 11:33:30 PM »

In some 0.97 games it was possible to display the hardest hit ever made by a player...

Well, with 0.98 such a feature wouldn't be possible - I think (at least I haven't found a soultion for that other than adding a modulehook into battle.php, line 138:
Code:
modulehook("damage", $roll);

Would there be another way beside this?
Logged

Running for more than three years now:
Nathan
Guest
« Reply #1 on: December 29, 2006, 05:36:42 AM »

Will you include this hook in the 1.1.1-battle.php?
Logged
Nightborn
Guest
« Reply #2 on: December 29, 2006, 07:35:50 AM »

I am certain it won't.

it is more than an everyhit hook.... every battleround, even if you "fight till the end" this hook is queried.

This means quite some load, which is not necessary.

I removed it from my server again as it was not prudent to take away performance just for that.
Logged
XChrisX
Global Moderator
Mod God
*****
Offline Offline

Posts: 4647

Be aware of the squirrel!


View Profile WWW
« Reply #3 on: December 29, 2006, 07:45:50 AM »

Will you include this hook in the 1.1.1-battle.php?
No, definately not.w
Logged

Running for more than three years now:
Nathan
Guest
« Reply #4 on: December 29, 2006, 08:14:12 AM »

Ok, so you will include the hardest hit in the core code...  Grin Wink
Logged
Nightborn
Guest
« Reply #5 on: December 29, 2006, 08:49:52 AM »

No, definately not.
Logged
Nathan
Guest
« Reply #6 on: December 29, 2006, 09:10:00 AM »

What a pity. If I'm not totally wrong, it won't take away much performance when stored in $session['user'].
Logged
Talisman
Administrator
Mod God
*****
Offline Offline

Posts: 5475



View Profile WWW
« Reply #7 on: December 29, 2006, 09:46:59 AM »

Storing it isn't so much a problem as calling the code with every round of the battle.  I'm afraid I agree with XChrisX and Nightborn, that this shouldn't be included in the core code.  Nor will a hook be added to support a single module without an exceptional reason, sorry...
Logged

Play the latest beta version here on DragonPrime
Nightborn
Guest
« Reply #8 on: December 29, 2006, 10:11:58 AM »

What a pity. If I'm not totally wrong, it won't take away much performance when stored in $session['user'].

sure. another field in the accounts table which is not vital for most parts of the game Wink like
| hauntedby        | varchar(50)         | NO   |     |                     |                |
| fedmount         | tinyint(4) unsigned | NO   |     | 0                   |                |
| boughtroomtoday  | tinyint(4)          | NO   |     | 0                   |                |

and so on... who are all stored there but not necessary for most parts... modules could handle it too. Wink

Talisman is right, it's not the storage itself, it's the extra code that is executed there... for... well, just cosmetic reasons... I don't  the see "hardest hit" as a game essential.

If you insist on it, do the changes and install the hardest hit module, you are free to do so.
Logged
Pages: [1]   Go Up
  Print  
 
Jump to:  


*
DragonPrime Notices
Welcome to DragonPrime - The LoGD Resource Community!

Support Us
No funds raised yet this year
Your help is greatly appreciated!
Recent Topics
DragonPrime LoGD
Who's Online
31 Guests, 0 Users
Home Forums News Downloads Login Register Advanced Search