Discussion - Mail Keeper

[Brendan]

Name Mail Keeper
Author Brendan for Sara
Version 1.1

Description
Keeps all mail even if they have been deleted and mega users can view them from the grotto, requested by Sara.
http://dragonprime.net/index.php?topic=12129.msg101044;topicseen#new

There is one small core edit

Code:

<?php
//open /lib/systemmail.php

//find line 40
$sql = "INSERT INTO " . db_prefix("mail") . " (msgfrom,msgto,subject,body,sent,originator) VALUES ('".$from."','".(int)$to."','$subject','$body','".date("Y-m-d H:i:s")."', ".($session['user']['acctid']).")";

//add this under it
//Mail keeper
if (db_table_exists(db_prefix('mailkeeper'))){
$mailkeeper = "INSERT INTO " . db_prefix("mailkeeper") . " VALUES ('','$from','$to','$subject','$body','".date("Y-m-d H:i:s")."','')";
db_query($mailkeeper);
}

//save
?>

Comments, suggestions

Download
http://dragonprime.net/index.php?topic=12145.msg101046;topicseen#new

[Minato™]

<ghost>
 
 *floats in like the ghost of an old coder*

   Wooo! the upgrade unfriendliness!

</ghost>

Seriously though, nice job Brendan.   Useful bit. Sure you don't want to release it for that 1.1.3 I've heard so much about?   lol

[Brendan]

Yeah there isn't an hook for the systemmail to hook in too so i had too do a small core edit  

Seriously though, nice job Brendan.   Useful bit. Sure you don't want to release it for that 1.1.3 I've heard so much about?   lol

lol 

[Megan|SaraBeth]

Amazing work...Is there a way to set a delete button in there.  So it will delete all YoMs in the Keeper but only have the delete button work for account 1?

[Aeo •]

Amazing work...Is there a way to set a delete button in there.  So it will delete all YoMs in the Keeper but only have the delete button work for account 1?

Attached.

EDIT: For those that don't want system mail appearing in the Mail Keeper, change the first line of the required core edit of lib/systemmail.php from:

Code:

<?php
if (db_table_exists(db_prefix('mailkeeper'))){
?>

to:

Code:

<?php
if (db_table_exists(db_prefix('mailkeeper')) && $from!=0){
?>

[Megan|SaraBeth]

Thank you so much!  It works great now!

[Megan|SaraBeth]

Anyway to have a search function on it that works like the search on Letter Opener?  So that way you can see all the saved mail for one specific person.

[Aeo •]

Anyway to have a search function on it that works like the search on Letter Opener?  So that way you can see all the saved mail for one specific person.

Have you had a look at the Letter Opener code, and seen if you can implement it into this module?

[Megan|SaraBeth]

It has a search.  I saw it afterward but it doesnt work properly. I tried to use it and it returns nothing.  What I want now is for that to be fixed and for it to be changed and be like letter opener and only save the last x amount of YoMs, thats admin settable.  So that way it doesnt stop after sometime of working or lag bad.

[Aeo •]

It has a search.  I saw it afterward but it doesnt work properly. I tried to use it and it returns nothing.  What I want now is for that to be fixed and for it to be changed and be like letter opener and only save the last x amount of YoMs, thats admin settable.  So that way it doesnt stop after sometime of working or lag bad.

That should be easy. Have a look through the code, and when you find the database call that gets all the mail in the database table, add an limit command to the end of it.

[Megan|SaraBeth]

So find the one that is used in the Letter Opener and use that and it would work?  And what about fixing the search function?

[Aeo •]

Edited module attached. (I got bored. I code when I get bored. xD)

• Search now works.
• Limit can be set in module settings

[HunterD]

Limit's nice.. but how about paginating it so we can view additional messages from a "Page 2", etc. nav?

Something like...

Code:

<?php
 $mailperpage = 50;
       $sql = "SELECT count(id) AS c from ".db_prefix("mailkeeper");
       $result = db_query($sql);
       $row = db_fetch_assoc($result);
       $totalpages = ceil($row['c']/$mailperpage);
         $page = httpget("page");
       if ($page == "") {
     if (isset($session['mailkeeperPage'])){
   $page = (int)$session['mailkeeperPage'];
}else{
$page = 1;
}
}
if ($page < 1) $page = 1;
if ($page > $totalpages) $page = $totalpages;
$session['mailkeeperPage'] = $page;

// No need to show the pages if there is only one.
if ($totalpages != 1)  {
addnav("Page");
for ($x=1; $x <= $totalpages; $x++){
if ($page == $x){
addnav(array("`b`#Page %s`0`b", $x),"runmodule.php?module=mailkeeper&page=$x");
}else{
addnav(array("Page %s", $x),"runmodule.php?module=mailkeeper&page=$x");
}
}
}
if ($page > 1){
$limit = (($page-1) * $mailperpage) . "," . $mailperpage;
}else{
$limit = "$mailperpage";
}
?>

Only... working? xD

That's from the petition viewer, by the way.  Fastest thing I could think of. Ideas?

[Aeo •]

Limit's nice.. but how about paginating it so we can view additional messages from a "Page 2", etc. nav?

Clever idea, sir. I've already started working on it - I'll have something up by the end of the night.

[Neltharion]

Sounds good.