Database Table not creating

[Aeo •]

So, I have this module rpalignment, with the install function thus:

Code:

<?php
function rpalignment_install(){
include_once("modules/rpalignment/install.php");
return true;
}
?>

and the modules/rpalignment/install.php files goes as thus:

Code:

<?php
// database table creation
if (!db_table_exists(db_prefix("rpalignment"))){
$sql = "CREATE TABLE `".db_prefix("rpalignment")."` (
  `name` varchar(255) NOT NULL default 'General',
  `id` int(11) NOT NULL auto_increment,
  PRIMARY KEY  (`id`)
) TYPE=MyISAM COMMENT='This holds the rp alighment info for the Roleplay Alignment module.' AUTO_INCREMENT=1 ;";
db_query($sql);
}

// module hooks
module_addhook("biostat");
module_addhook("village");
module_addhook("superuser");
module_addhook("charstats");
module_addhook("header-village");
module_addhook("newday");
module_addhook("shades");
?>

However, when installing and activating the module, the database table rpalignment will not create, even though the whole module, database table and all, works PERFECTLY on my development server. >.< Anyone know of a fix or error I've done?

[Loscil Derails]

I'm not sure off of the top of my head what is the problem, but here are some things to check:

1) Did you make sure in the db that it didn't actually create? While it sounds like you have, I'm not sure if you were just going by if the module works or not.
2) Is your live DB a different build/version than your dev db?
3) Does it depend on any modules that you have active on your dev server but not on your live version? (If you wrote this module, did you remember to include dependencies?)
4) If uninstall and reinstall works perfectly on your dev server, it is unlikely you have a syntax error, unless there is anything that you changed the name of on your dev server and not on your live server (or vice versa: example, renaming a module, or anything)

That's all I can think of for now, if I see anything or think of anything else I'll let you know.

[KaosKaizer]

Also, are the MySQL versions on the two servers the same, or are they different? I don't think MySQL v5.5 supports "Type" anymore. You may have to relace it with "engine" and see how that works.

[Brendan]

Its the type.

EDIT..
Yeah what Kaizer said 

[Aeo •]

You may have to relace it with "engine" and see how that works.

Its the type.

My thanks! It works as it's meant to now.

That's all I can think of for now, if I see anything or think of anything else I'll let you know.

Also, thanks valor for your help, too.

[Loscil Derails]

Also, are the MySQL versions on the two servers the same, or are they different? I don't think MySQL v5.5 supports "Type" anymore. You may have to relace it with "engine" and see how that works.

This is what I meant in my number 2 option. ^^;

[Boris735]

You can avoid some of these issues -- or at least make them the fault of Green Dragon code -- by using synctable() (preferred) or table_create_from_descriptor() to create the table.

The benefits of this layer of abstraction are that those functions can, in principle, cope with different database requirements (so, for instance, that you don't have to think about whether ISAM or INNODB is the right one to use, or whatever later engines are invented) and also that synctable() will adjust the table if need be.  This latter is particularly handy when you decide you want a new column in the table, since you only need to change the definition and not write the checking code yourself.

The corresponding code for your example would be (note that no check is required for whether the table already exists):

Code:

$rpdesc = array(
  'id' => array('name' => 'id', 'type' => 'int(11)', 'extra' => 'auto_increment'),
  'name' => array('name' => 'name', 'type' => 'varchar(255)', 'default' => 'General'),
  'key-PRIMARY' => array('name' => 'PRIMARY', 'type' => 'primary key', 'unique' => '1', 'columns' => 'id')
);
synctable(db_prefix("rpalignment"), $rpdesc);