By reset I mean default, what it was originally.
The function calculate_buff_fields() in buffs.php puts $session['user']['superuser'] into a defined constant and of course once it has been defined then that's it until the end of the script run.
If you have more than 1 buff, they wont all pass through this function one after the other. Instead I've noticed that other code (modules) will often run in between and here lies the problem.
If the constant is defined with the first buff and then a module is run, a module which alters the ['superuser'] value, and then another buff goes through the function, the ['superuser'] value will default back to what it was originally.
Is this constant to stop buffs altering the ['superuser'] value?
Could something like this do the same,
<?php
//
// Line: 41
//
if ($value != $origstring && $value != 'superuser'){
