DragonPrime - LoGD Resource Community
Welcome Guest
  • Good evening, Guest.
    Please log in, or register.
  • July 21, 2018, 12:28:52 AM
Home Forums News Downloads Login Register Advanced Search
* * *
DragonPrime Menu
Login
 
 
Resource Pages
Search

Poll
Question: Do we need a team to review modules, and a controlled download point for the good ones?
Yes!  As a coder, I would submit my modules and find this useful. - 29 (30.5%)
No.  I can't be bothered taking my modules to the next level.  They're fine where they are. - 2 (2.1%)
<Shrug>  I dunno...maybe, but I don't really know if it would be worth it. - 9 (9.5%)
Yes!  As a server admin, I would find this very useful for finding good modules. - 49 (51.6%)
No.  As a server admin, I don't really care.  Just keep feeding us modules. - 6 (6.3%)
Total Voters: 44

Pages: [1] 2 3   Go Down
  Print  
Author Topic: Module Review Team  (Read 14245 times)
0 Members and 1 Guest are viewing this topic.
Talisman
Administrator
Mod God
*****
Offline Offline

Posts: 5479



View Profile WWW
« on: September 08, 2005, 12:50:42 PM »

Based on the suggestions of Dannic and others, along with the obvious need for providing better listings of completed modules with more information, I would like to suggest that we form a Module Review Team.

I don't intend for the process to become as formalized as what may have been suggested before, but I would like a method by which the author of a module may submit it for review and subsequent listing on a controlled page.

Let's discuss the following steps:

1.  Authors submit their tested and hopefully bug free mods for review
2.  The review team checks for code issues including translation readiness
3.  The item is placed on the hosted completed mods page with assorted other information

Step 1:  Once a module has spent some time in the completed modules list (or possibly a module assessment thread) where people can access, test and provide feedback on it, the author can submit it for review.  Ancilliary to this, modules uploaded by members no longer active in the DragonPrime or LoGD community will be reviewed for possible inclusion in the list.

Step 2:  One or more people from a small core of proven coders will take a look at the code.  Small corrections could be made at this time, or the module referred back to the author with a list of what's needed.  This would not be an opportunity for novice coders to have someone tutor them on their coding.  We would look at such traits as translation readiness, 'good coding' procedures, and credit information where appropriate.  Things relating to generic coding protocols (indents, etc) would be at the discretion of the reviewer, but certainly not required.

Step 3:  Files which prove to be (relatively) bugfree and translation ready will be hosted by DragonPrime vice the original author.  There will be some worthwhile benefits of this, not the least of which is a download counter to observe the popularity of each module, and possibly a user fed rating system.

As convenient as the current file sharing system is, I'm quite limited in what utilities I can add to it.  There are a number of major issues which could be overcome with a stable module list.

The entire process is intended to be very informal and not a lengthy one.  What I need, apart from feedback and suggestions from the community as a whole, are some volunteers with a solid background in LoGD coding to become members of the team. 

DO NOT POST YOUR NAMES HERE; If you're interested, IM me directly.
« Last Edit: April 30, 2007, 06:49:32 PM by Talisman » Logged

Play the latest beta version here on DragonPrime
Kendaer
Guest
« Reply #1 on: September 08, 2005, 04:17:47 PM »

One other thing, and this ties into something I've been discussing/considering is that this team COULD make recommendations that a certain module be included as part of the core.

Guidelines for the core modules should be:
1) Provides a useful (or fun) service/feature that a MAJORITY of servers would find useful/nice to have out of the box.
2) Provides a novel/new way of implementing something that can be used as demonstration
3) Currently in active use on either Dragoncat.net or Central Smiley (this is just because 99% of the modules I write or that are written by the central staff will wind up in the core  -- it's just easier that way Smiley)

Basically, I don't think every module in the world should be in the core, but I'm sure there are modules which could/should be.

A random forest special, or a new race probably shouldn't be in the core and should be left on dragonprime.
Things which make the life easier for a lot of admins, probably should be in the core.
Unusually interesting ideas/concepts/capabilities possibly, depends on how widely interesting it should be.

I am pretty sure that there are modules here on dragonprime which should be in the core and aren't simply because I don't have the time to do this level of review of all the code which is provided here.   I'm also sure that there are modules here which really shouldn't be, and there are in fact probably modules in the core which don't need to belong there (see bullet number three above Smiley)

And of course, the author would have to want their code to be part of the core as well and be willing to undertake the effort to make sure their most recent versions were in the core, etc.

Logged
sixf00t4
Mod God
*****
Offline Offline

Posts: 1916



View Profile WWW
« Reply #2 on: September 09, 2005, 02:08:29 PM »

I've searched the forum deeper than i've ever searched before, and I can't find the thread we had on this idea before.  it was definitely over a year ago.  Possibly still in the 9.7 days.  Robert and lonny were involved in it...we all came up with good reasons why this is not the best idea.  Do you remember it tal?
Logged

lonnyl
Guest
« Reply #3 on: September 27, 2005, 01:49:29 PM »

Actually the suggestion was for 0.98.... and it was more along the lines of stamping the modules with little flags in the forum.... like the little new tag you see... but it would be a translation ready tag... etc.... The idea was to make a few volunteers responsible to checking translation readiness and so on....
Logged
Elessa
Faerie
Mod God
*****
Offline Offline

Posts: 3598


short, sweet and to the point


View Profile
« Reply #4 on: September 27, 2005, 02:50:51 PM »

* Elessa rummages around a little with the search function now that she has a bit more to work with and finds

module flags

after searching previously and coming up empty handed, thanks to lonnyl's post, i think this is the thread that sixf00t4 may hath been thinking of.  
Logged

Uuma ma ten rashwe, ta tuluva a lle

Play the latest beta version here on LoGD DragonPrime - Axebridge
Mr Zone
Captain of the Guard
***
Offline Offline

Posts: 175


what am I?


View Profile WWW
« Reply #5 on: November 29, 2005, 11:56:28 AM »

Just a few ideas!!!

A module review team could do some simple things. First off, we should categorize them much better. Not just Completed Forest & modules Races and Specialties, but by each main category. Forest, village, Lodge, admin and so on. Check out & install the mods to make they are bugfree. Also the team should not modify any code (even for translation, translation should be highly encouraged) unless the team wants to set up a special module download section to keep the updates they would make downloadable.

Again, I would be glad to assist on this team.  
Logged



" Im Sane And the rest of the world is Insane, and trying to steal my magic Beans!!!"
Dannic
Guest
« Reply #6 on: November 29, 2005, 04:28:29 PM »


Again, I would be glad to assist on this team.  


DO NOT POST YOUR NAMES HERE; If you're interested, IM me directly.

« Last Edit: November 29, 2005, 04:29:03 PM by Dannic » Logged
aSeekr
Guest
« Reply #7 on: February 01, 2006, 11:19:01 PM »

*2 cents*
You could use some tools - ala nUnit to do a first pass of modules to ensure robustness.
Maybe module developers could supply their own tests with a module which could then be run against the module on a site to ensure that all is ok.
Logged
ThricebornPhoenix
Codemeister
****
Offline Offline

Posts: 370


Dying is the easy part.


View Profile
« Reply #8 on: February 16, 2007, 11:59:26 PM »

It seems that this hasn't got off the ground yet (my apologies if I'm wrong), and that's a shame. With the seperation of most modules from the core, the ongoing development of core code (which in the worst case may cause modules to lose vital functionality), and the increasing age of this community (more modules falling victim to obsolescence, and a greater number of modules overall), I think this is needed now more than ever before.

It may be best not to implement this until after the download system has been upgraded, but there should be plenty of room for discussion. Smiley

My two GP: modules could (almost) immediately be labeled according to how well they seem to work with each version of LotGD - e.g.
1.0.6 - severely buggy
1.1.0 - functionally buggy
1.1.1 - functional

Just examples, of course. There would also be 'approved' status for modules which pass the three steps proposed by Talisman (entirely optional on the author's part, though I think beneficial). Feedback from players, admins, and the module authors themselves ought to take care of anything less than approved status, thus - hopefully - reducing the amount of work for the review team. Naturally, the modules in the 'recommended modules pack' would have approved status for the latest stable release, although this system would in fact remove the need for it.

Thoughts?
Logged

"I was talking aloud to myself. A habit of the old: they choose the wisest person present to speak to; the long explanations needed by the young are wearying."
Nightborn
Guest
« Reply #9 on: February 17, 2007, 12:40:00 AM »

 Grin yes.

Who should do this?

A couple hundred modules here, and to test with 3 versions *THOROUGHLY* (because you can never test it ALL, believe me) is quite a bit.

The best would be for the *module author* to make notes to a module ... he usually maintains it.

If he does not, well, then it is "inactive"
Logged
ThricebornPhoenix
Codemeister
****
Offline Offline

Posts: 370


Dying is the easy part.


View Profile
« Reply #10 on: February 17, 2007, 01:50:33 AM »

Who should do this?

A couple hundred modules here, and to test with 3 versions *THOROUGHLY* (because you can never test it ALL, believe me) is quite a bit.

It may take a long time to fill in all the blanks, true, but I think it's doable. The DragonPrime community as a whole could contribute feedback based on their experiences with such-and-such modules, and judging by the votes, many module authors would try to do their part.

And the alternative is to let enough time go by that this task becomes impossible.


The best would be for the *module author* to make notes to a module ... he usually maintains it.

If he does not, well, then it is "inactive"

The best way to get this to happen, I think, would be to set a simple and exact standard for how to do this.

Inactive modules could still be rated based on feedback from people who use them - better yet, one such person would take over updating, if the module is good Wink
Logged

"I was talking aloud to myself. A habit of the old: they choose the wisest person present to speak to; the long explanations needed by the young are wearying."
Nightborn
Guest
« Reply #11 on: February 17, 2007, 05:51:46 AM »

And then... we need a download system with much more option, i.e. the rank and category =)

Talisman is now struggling alone to get a suitable solution.

It's pretty hard. =)

I do not know  this "person" who should decide whether it is "good" or not =)
Logged
XChrisX
Global Moderator
Mod God
*****
Offline Offline

Posts: 4647

Be aware of the squirrel!


View Profile WWW
« Reply #12 on: February 17, 2007, 06:00:10 AM »

And, what may be good for one site may be the worst possible module for another site...
Logged

Running for more than three years now:
ThricebornPhoenix
Codemeister
****
Offline Offline

Posts: 370


Dying is the easy part.


View Profile
« Reply #13 on: February 17, 2007, 06:18:16 AM »

It seems that 'nay' is a popular word around here. Tongue

And then... we need a download system with much more option, i.e. the rank and category =)

Talisman is now struggling alone to get a suitable solution.

That's why we don't set anything in stone until he's got that figured out. Wink

And, what may be good for one site may be the worst possible module for another site...

I meant that in a general sense. A module that has severe bugs, where another module does the same thing (or better) without bugs, probably isn't 'good' for any site....
Logged

"I was talking aloud to myself. A habit of the old: they choose the wisest person present to speak to; the long explanations needed by the young are wearying."
Chewie
Captain of the Guard
***
Offline Offline

Posts: 154

Ignore this.


View Profile
« Reply #14 on: February 17, 2007, 06:29:11 AM »

A couple hundred modules here, and to test with 3 versions

Why with all three versions?  Don't get me wrong, it would be a great accomplishment, but maybe you're expecting too much from yourselves.  I think it would be sufficient that they only be tested for the most current stable release.  This would help focus your energies on moving forward, as well as encouraging the rest of the community to do the same.
Logged
Pages: [1] 2 3   Go Up
  Print  
 
Jump to:  


*
DragonPrime Notices
Play LoGD on Dragonprime

Support Us
No funds raised yet this year
Your help is greatly appreciated!
Recent Topics
DragonPrime LoGD
Who's Online
38 Guests, 0 Users
Home Forums News Downloads Login Register Advanced Search