Tournament98 question

enderwiggin

Guest

« on: January 17, 2005, 07:18:34 PM »

I was taking a peak at the code for the .9.8 version of the Tournament module. I'm planning on doing a Dwarf Toss module, and I was considering using the Tournament as somewhat of a template. I don't know how to get ahold of the person who did the conversion, and Talisman says he doesn't know anything about the conversion.

There are two lines:

case "dragonkill":
case "namechange":

Shouldn't every case end with a break? The dragonkill hook here is empty. Was something planned here and not implemented? Was something intentionally removed?

I'm just curious.


	Logged

dvd871

Guest

Re:Tournament98 question

« Reply #1 on: January 17, 2005, 08:44:52 PM »

The case does end with a break:

Code:

case "dragonkill":
case "namechange":
if ($leader == $session['user']['acctid']) {
invalidatedatacache("tournamentleader");
}
break;

You can have multiple cases in your switch, such as:
case 1: case 2:
.
.
.
break;

and also like the code fragment above.


	Logged

Arune

Member
Mod God

Offline

Posts: 718

Arune Vai - khatfield

Re:Tournament98 question

« Reply #2 on: January 19, 2005, 10:01:31 AM »

Exactly what dvd871 said.

By doing that he made both cases do the same thing. Instead of making two cases doing the exact same thing and wasting like 4 lines of space.

Example:

Instead of -

Code:

case "dragonkill":
if ($leader == $session['user']['acctid']) {
invalidatedatacache("tournamentleader");
}
break;
case "namechange":
if ($leader == $session['user']['acctid']) {
invalidatedatacache("tournamentleader");
}
break;

It was more efficient to do:

Code:

case "dragonkill":
case "namechange":
if ($leader == $session['user']['acctid']) {
invalidatedatacache("tournamentleader");
}
break;


« Last Edit: January 19, 2005, 10:01:52 AM by Arune »	Logged

Pages: [1] Go Up

DragonPrime - LoGD Resource Community > Modules, Themes and other customizations for your game > Completed Modules for version 1.x.x (Moderator: GenmaC) > Topic: Tournament98 question

« previous next »